From: Florian Müllner <fmuellner@gnome.org>
Date: Tue, 28 Jul 2020 16:52:53 +0000 (+0200)
Subject: panelMenu: Destroy menu before chaining up
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~86
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1812db7aa80e3763f56b3cc41a162b9eb1b62b3e;p=gnome-shell.git

panelMenu: Destroy menu before chaining up

This avoid some (harmless but annoying) warnings, and is closer to
the original code prior to commit fc342fe8c5 and 557b232c896.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3022
---

diff --git a/js/ui/panelMenu.js b/js/ui/panelMenu.js
index 44fd763ba..81d34490b 100644
--- a/js/ui/panelMenu.js
+++ b/js/ui/panelMenu.js
@@ -183,10 +183,9 @@ var Button = GObject.registerClass({
     }
 
     _onDestroy() {
-        super._onDestroy();
-
         if (this.menu)
             this.menu.destroy();
+        super._onDestroy();
     }
 });